JavaScript Ne(eeeeee)rds. Help gotten! Issue solved. All hail Crowmolly!

Nibby > anonsagainstanonymous 03/19/2014 at 12:15

0

Next time, link to a pastebin?

Eric the RC guy > anonsagainstanonymous 03/19/2014 at 12:18

0

Can you post the full code with HTML since I'm too lazy to recreate it?

Global variables are screwy in javascript so I recommend against using them, let your functions return values instead.

vorspringing > anonsagainstanonymous 03/19/2014 at 12:26

0

No worries. Looking at it, I don't see where you're making changes to either of those variables within the dataPrompt function itself, which means it's going to return 0 for both values.

crowmolly > anonsagainstanonymous 03/19/2014 at 12:26

0

var cost; var costNumber; var cash; var cashNumber; var cashBack; var costText = ("Cost of merchandise"); var cashText = ("Cash Paid");

function costPrompt() { costNumber = dataPrompt(cost, costText, costNumber, costPrompt); }

function cashPrompt() { cashNumber = dataPrompt(cash, cashText, cashNumber, cashPrompt); }

function dataPrompt(x, y, z, a) { x = prompt (y); z = parseFloat(x); console.log (z); console.log (a); if (isNaN(z)) { alert ("That's not a number, cumface. Try again."); a(); } return z; }

costPrompt();

cashPrompt();

alert("costNumber " + costNumber);

alert("cashNumber " + cashNumber);

Terrible formatting is terrible.

But you get the basic idea. Return the values.

anonsagainstanonymous > Eric the RC guy 03/19/2014 at 12:27

0

http://pastebin.com/JcqAzdy0 I've been trying to figure out how to use the return function. I've got it working so-so at this point.

anonsagainstanonymous > Nibby 03/19/2014 at 12:27

0

Thank you! I'd completely forgotten about pastebin

anonsagainstanonymous > crowmolly 03/19/2014 at 12:29

0

terrible kinja is terrible kinja. Thank you! I'll try and decipher this.

anonsagainstanonymous > crowmolly 03/19/2014 at 12:33

1

whoah it worked! That was so much simpler than other examples I've seen. Thank you very much!

anonsagainstanonymous > vorspringing 03/19/2014 at 12:37

0

Thank you. I got it working thanks to crowmolly. they showed me a very simple way to do this and I'm eternally grateful.

David Talmage > anonsagainstanonymous 03/19/2014 at 12:41

0

Your problem is that numbers in Javascript are passed by value not by reference. Make the {cost,cash,data}Prompt functions return a value. Assign the value to cashNumber or costNumber or whatever.

crowmolly > anonsagainstanonymous 03/19/2014 at 14:19

0

Wow, thanks for the title change! No worries, it's a question of variable scope. Global vars (as stated by somebody else I think) should be only used as a last resort.

CalzoneGolem > anonsagainstanonymous 03/19/2014 at 14:47

0

That's not a number, cumface. Try again.

Lol. Make sure that comes out before you move into production.

Eric the RC guy > anonsagainstanonymous 03/19/2014 at 16:59

0

Edit: I see that you already got this solved, sorry for the late response. I'll leave this here just as a basic explainer for return functions, they operate the same way in just about every language.

Sorry, I got super busy at work today and am about to leave now but I'll take a look at that code tomorrow morning and get back to you if you haven't got an answer by then.

The return function basically allows you to use a sub-routine to assign a value to a variable. IE (warning: pseudo-code ahead):

[code]
a = doMath(12,15);

function doMath(x as integer, y as integer) {
return x * y;
}
[/code]

That code will make a = 180. Letting functions return values eliminates issues with assigning global variables and worrying about variable scope. In general it is best practice to never use global variables in any language, and the reason I forced myself to learn to always do it that way is because every language handles global variables differently. If you never use them you never have to remember which language handles them in which way.

Eric the RC guy > CalzoneGolem 03/19/2014 at 17:00

1

What he said, I learned this the hard way.